Repository navigation
Use more precise typing for AWSElastiCacheHashClient - #659
Open
tim-schilling wants to merge 1 commit into
Open
tim-schilling wants to merge 1 commit into
tim-schilling wants to merge 1 commit into
Conversation
This fixes the mypy errors that are occurring in CI. The types are based on the comments and docstrings of HashClient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the mypy errors that are occurring in CI. The types are based on the comments and docstrings of HashClient.
This was generated with the help of Claude Sonnet. I explored whether or not to extend this to HashClient, but decided to keep it related to fixing mypy. This is still probably a bit more extensive than just fixing the mypy errors, but using
objectfor everything didn't seem "right". Happy to see this replaced by something better too.